Josh Bleecher Snyder b42e32047d device: call wg.Add outside the goroutine ...

One of the first rules of WaitGroups is that you call wg.Add
outside of a goroutine, not inside it. Fix this embarrassing mistake.

This prevents an extremely rare race condition (2 per 100,000 runs)
which could occur when attempting to start a new peer
concurrently with shutting down a device.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>

2021-01-07 14:49:44 +01:00

15 KiB

Raw Blame History

View Raw