device: make test setup more robust

Picking two free ports to use for a test is difficult.
The free port we selected might no longer be free when we reach
for it a second time.

On my machine, this failure mode led to failures approximately
once per thousand test runs.

Since failures are rare, and threading through and checking for
all possible errors is complicated, fix this with a big hammer:
Retry if either device fails to come up.

Also, if you accidentally pick the same port twice, delightful confusion ensues.
The handshake failures manifest as crypto errors, which look scary.
Again, fix with retries.

To make these retries easier to implement, use testing.T.Cleanup
instead of defer to close devices. This requires Go 1.14.
Update go.mod accordingly. Go 1.13 is no longer supported anyway.

With these fixes, 'go test -race' ran 100,000 times without failure.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
This commit is contained in:
Josh Bleecher Snyder
2020-12-08 19:23:56 -08:00
committed by Jason A. Donenfeld
parent ca9edf1c63
commit 3591acba76
2 changed files with 65 additions and 29 deletions

2
go.mod
View File

@@ -1,6 +1,6 @@
module golang.zx2c4.com/wireguard
go 1.13
go 1.14
require (
golang.org/x/crypto v0.0.0-20201124201722-c8d3bf9c5392