From 7e5827068366b6d299d35cfbebaa427878ce6661 Mon Sep 17 00:00:00 2001 From: Jack McNicol Date: Fri, 22 Jul 2016 02:12:13 +0930 Subject: [PATCH 1/4] set webroot default folder --- scripts/start.sh | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/scripts/start.sh b/scripts/start.sh index bb660fe..a93f151 100644 --- a/scripts/start.sh +++ b/scripts/start.sh @@ -13,7 +13,10 @@ fi # Set custom webroot if [ ! -z "$WEBROOT" ]; then - sed -i "s#root /var/www/html;#root ${WEBROOT};#g" /etc/nginx/sites-available/default.conf + webroot=$WEBROOT + sed -i "s#root /var/www/html;#root ${webroot};#g" /etc/nginx/sites-available/default.conf +else + webroot=/var/www/html fi # Setup git variables @@ -26,15 +29,15 @@ if [ ! -z "$GIT_NAME" ]; then fi # Dont pull code down if the .git folder exists -if [ ! -d "/var/www/html/.git" ]; then +if [ ! -d "${webroot}/.git" ]; then # Pull down code from git for our site! if [ ! -z "$GIT_REPO" ]; then # Remove the test index file rm -Rf /var/www/html/index.php if [ ! -z "$GIT_BRANCH" ]; then - git clone -b $GIT_BRANCH $GIT_REPO /var/www/html/ + git clone -b $GIT_BRANCH $GIT_REPO $webroot else - git clone $GIT_REPO /var/www/html/ + git clone $GIT_REPO $webroot fi chown -Rf nginx.nginx /var/www/html fi From 52ef7b848c76f1e0858552dcd6a16d1c5f895efe Mon Sep 17 00:00:00 2001 From: Jack McNicol Date: Fri, 22 Jul 2016 02:13:17 +0930 Subject: [PATCH 2/4] always chown webroot for better mounting --- scripts/start.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/start.sh b/scripts/start.sh index a93f151..db883ed 100644 --- a/scripts/start.sh +++ b/scripts/start.sh @@ -39,7 +39,6 @@ if [ ! -d "${webroot}/.git" ]; then else git clone $GIT_REPO $webroot fi - chown -Rf nginx.nginx /var/www/html fi fi @@ -85,5 +84,8 @@ if [[ "$TEMPLATE_NGINX_HTML" == "1" ]] ; then done fi +# Always chown webroot for better mounting +chown -Rf nginx.nginx $webroot + # Start supervisord and services /usr/bin/supervisord -n -c /etc/supervisord.conf From e741466e76c8889b3481697ce24b490f89179163 Mon Sep 17 00:00:00 2001 From: Jack McNicol Date: Fri, 22 Jul 2016 02:41:58 +0930 Subject: [PATCH 3/4] replace fpm conf with env var --- scripts/start.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/start.sh b/scripts/start.sh index db883ed..4d5c846 100644 --- a/scripts/start.sh +++ b/scripts/start.sh @@ -44,9 +44,9 @@ fi # Display PHP error's or not if [[ "$ERRORS" != "1" ]] ; then - echo php_flag[display_errors] = off >> /etc/php5/php-fpm.conf + echo php_flag[display_errors] = off >> $fpm_conf else - echo php_flag[display_errors] = on >> /etc/php5/php-fpm.conf + echo php_flag[display_errors] = on >> $fpm_conf fi # Display Version Details or not From a90c60009ca69f5545a0c0754544c303ae8bad69 Mon Sep 17 00:00:00 2001 From: Jack McNicol Date: Fri, 22 Jul 2016 02:43:37 +0930 Subject: [PATCH 4/4] set clear_env => no enables $_ENV[] can be used without hack sed replace --- Dockerfile | 3 ++- scripts/start.sh | 13 ------------- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/Dockerfile b/Dockerfile index 7de2634..e3b09b6 100644 --- a/Dockerfile +++ b/Dockerfile @@ -2,7 +2,7 @@ FROM alpine:3.4 MAINTAINER ngineered -ENV php_conf /etc/php5/php.ini +ENV php_conf /etc/php5/php.ini ENV fpm_conf /etc/php5/php-fpm.conf ENV composer_hash e115a8dc7871f15d853148a7fbac7da27d6c0030b848d9b3dc09e2a0388afed865e6a3d6b3c0fad45c48e2b5fc1196ae @@ -77,6 +77,7 @@ sed -i -e "s/;listen.mode = 0660/listen.mode = 0666/g" ${fpm_conf} && \ sed -i -e "s/;listen.owner = nobody/listen.owner = nginx/g" ${fpm_conf} && \ sed -i -e "s/;listen.group = nobody/listen.group = nginx/g" ${fpm_conf} && \ sed -i -e "s/listen = 127.0.0.1:9000/listen = \/var\/run\/php-fpm.sock/g" ${fpm_conf} &&\ +sed -i -e "s/^;clear_env = no$/clear_env = no/" ${fpm_conf} &&\ ln -s /etc/php5/php.ini /etc/php5/conf.d/php.ini && \ find /etc/php5/conf.d/ -name "*.ini" -exec sed -i -re 's/^(\s*)#(.*)/\1;\2/g' {} \; diff --git a/scripts/start.sh b/scripts/start.sh index 4d5c846..8e653a4 100644 --- a/scripts/start.sh +++ b/scripts/start.sh @@ -71,19 +71,6 @@ if [ ! -z "$PHP_UPLOAD_MAX_FILESIZE" ]; then sed -i "s/upload_max_filesize = 100M/upload_max_filesize= ${PHP_UPLOAD_MAX_FILESIZE}M/g" /etc/php5/conf.d/php.ini fi -# Very dirty hack to replace variables in code with ENVIRONMENT values -if [[ "$TEMPLATE_NGINX_HTML" == "1" ]] ; then - for i in $(env) - do - variable=$(echo "$i" | cut -d'=' -f1) - value=$(echo "$i" | cut -d'=' -f2) - if [[ "$variable" != '%s' ]] ; then - replace='\$\$_'${variable}'_\$\$' - find /var/www/html -type f -exec sed -i -e 's/'${replace}'/'${value}'/g' {} \; - fi - done -fi - # Always chown webroot for better mounting chown -Rf nginx.nginx $webroot